Notate throwing vs. non-throwing abstract operations #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1833,7 +1844,7 @@ throughout the rest of this standard. | |||
| 1. Return *undefined*. | |||
| </emu-alg> | |||
|
|
|||
| <h4 id="get-total-queue-size" aoid="GetTotalQueueSize">GetTotalQueueSize ( queue )</h4> | |||
| <h4 id="get-total-queue-size" aoid="GetTotalQueueSize" throws>GetTotalQueueSize ( queue )</h4> | |||
|
Reviewed annotations! |
domenic
force-pushed
the
notate-throws
branch
4 times, most recently
from
2684999
to
43a49ab
Compare
|
Thanks for the careful review; both of your throw -> nothrow finds were correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371.
@tyoshino, pretty sure this is correct, but if you could do a quick check to make sure my throw/nothrow annotations are OK, that'd be helpful.