Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should ReadableStreamClose() resolve BYOB reader readIntoRequests? #455

Closed
wanderview opened this issue May 25, 2016 · 3 comments
Closed

Comments

@wanderview
Copy link
Member

In ReadableStreamClose() we iterate over default reader's readRequests to resolve all of their promises. We don't, however, do this for BYOB reader readIntoRequests. Is this intentional?

Note that we do iterate and reject BYOB reader readIntoRequests in ReadableStreamError().

@tyoshino
Copy link
Member

This is for allowing the underlying byte source to return the buffers it borrowed even after being canceled. We're still discussing whether this is really useful or not. Your opinion is really welcome.

We had this logic also for errored state, but we've removed it.

@domenic
Copy link
Member

domenic commented Aug 4, 2016

@wanderview did you have an opinion on this?

@wanderview
Copy link
Member Author

I'm willing to defer here. It was just something I noticed at a local level, but not sure I fully understand the total system implication yet.

@domenic domenic closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants