Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOF after stand-alone drive-letter. #304

Closed
alwinb opened this issue Apr 29, 2017 · 1 comment
Closed

EOF after stand-alone drive-letter. #304

alwinb opened this issue Apr 29, 2017 · 1 comment

Comments

@alwinb
Copy link
Contributor

alwinb commented Apr 29, 2017 •
edited
Loading

The reference implementation currently parses C| against file://host/dir/file as file://host/dir/C|.

Against the same base URL,

  • C| is parsed as file://host/dir/C|
  • C|# is parsed as file:///C:#
  • C|? is parsed as file:///C:?
  • C|/ is parsed as file:///C:/
  • /C| is parsed as file:///C:
  • etc,

I am not (yet) sure if this is according to the current specification or an issue with the reference implementation. I would propose changing this behaviour to have C| yield file:///C:.
@rmisev
Copy link
Member

rmisev commented Apr 30, 2017 •
edited
Loading

It's an issue of current specification. It looks like the cause is a logic error in the file state of basic URL parser. The base's path is copied, because C| satisfies the condition (remaining in this case is |):

  • remaining consists of one code point

I will try to fix it.

rmisev added a commit to rmisev/url that referenced this issue Apr 30, 2017
@rmisev
Fix: windows drive letter handling in the file state
d671fd9 
Fixes whatwg#304
@rmisev rmisev mentioned this issue Apr 30, 2017
Merged
annevk pushed a commit that referenced this issue May 3, 2017
@rmisev @annevk
Fix Windows drive letter handling in the file state
fe6b251 
Tests: web-platform-tests/wpt#5754.

Fixes #304.
triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this issue May 3, 2017
@triple-underscore
[URL] Fix Windows drive letter handling in the file state whatwg/url@f…
1d10ae4 
…e6b251

Fixes whatwg/url#304

和訳には織り込み済み（原文を論理的な対偶に変換している ＋ ［ ε  の利用］による結果、修正不要）
rmisev added a commit to upa-url/upa that referenced this issue May 24, 2020
@rmisev
Test samples from whatwg/url#304
d60d4d7
rmisev added a commit to upa-url/upa that referenced this issue May 24, 2020
@rmisev
Fix windows drive letter handling in the file state
12a23a5 
URL statndard issue: whatwg/url#304

Follows whatwg/url#305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alwinb @rmisev