Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an "exclude credentials" flag to the URL serializer. #476

Closed
mikewest opened this issue Apr 16, 2020 · 4 comments
Closed
Labels
topic: model For issues with the abstract-but-normative bits

Comments

@mikewest
Copy link
Member

It seems to me that there are more than a few places where we strip username and password from a URL, then pass it to the URL serializer with the exclude fragment flag set. Perhaps we could simplify this by adding an exclude credentials flag as well?

Is that a patch you'd accept, @annevk?

@annevk
Copy link
Member

annevk commented Apr 16, 2020

Seems reasonable. I'm be a little worried about them surviving accidentally, but I should probably trust the callers.

I haven't seen this pattern much myself, but perhaps I'm not stripping them as much as I should have...

@annevk annevk added the topic: model For issues with the abstract-but-normative bits label Apr 26, 2020
@annevk
Copy link
Member

annevk commented Jun 2, 2020

Does whatwg/fetch#1028 obsolete this? Or do we not always have a request?

@annevk
Copy link
Member

annevk commented Oct 20, 2021

@mikewest ping.

@mikewest
Copy link
Member Author

I think this isn't a thing anyone is working on, and it's not enough of a concern to make it anything like a priority. Let's close it out, and think about it again if we add another spot that strips credentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: model For issues with the abstract-but-normative bits
Development

No branches or pull requests

2 participants