Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deduplication attempt #205

Closed
wants to merge 17 commits into from
Closed

deduplication attempt #205

wants to merge 17 commits into from

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 15, 2017

No description provided.

@annevk
Copy link
Member Author

annevk commented Jan 15, 2017

I have no idea why this starts five build jobs, one per variable. https://docs.travis-ci.com/user/environment-variables/#Defining-public-variables-in-.travis.yml suggests I'm doing this correctly.

@annevk annevk mentioned this pull request Jan 15, 2017
Closed
@annevk
Copy link
Member Author

annevk commented Jan 15, 2017

Yay for https://stackoverflow.com/questions/40294597/how-to-properly-define-multiple-env-variables-on-travis-yml.

@annevk annevk mentioned this pull request Jan 17, 2017
Closed
@domenic domenic mentioned this pull request Jan 23, 2017
Closed
@domenic
Deduce title from Bikeshed
f1af34d 
Deduplication is always nice
annevk
annevk commented Jan 24, 2017
View reviewed changes
Copy link
Member Author

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only worry I have here is about not copying the .htaccess. Perhaps we should start with a repository that does not require additional resources to be copied?

.gitattributes
@@ -0,0 +1,2 @@
* text=auto eol=lf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per feedback the eol=lf is redundant.

@domenic
Copy link
Member

domenic commented Jan 24, 2017

Closing for now and using whatwg/dom as our new test subject.

@domenic domenic closed this Jan 24, 2017
@annevk annevk deleted the annevk/experiment-for-meta branch January 24, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic