Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how URL strings map to URL getters via table #490

Closed
wants to merge 1 commit into from

Conversation

annevk
Copy link
Member

@annevk annevk commented May 4, 2020

Helps with #337.


Preview | Diff

@domenic
Copy link
Member

domenic commented May 4, 2020

I think omitting origin and host removes most of the value of such a table, unfortunately. Those are the confusing cases where an example is most helpful.

@annevk
Copy link
Member Author

annevk commented May 4, 2020

I suppose I could see how wide the table gets. Where would you put them? Or are you thinking about the multiple rows approach? (I didn't really like how that ended up looking.)

@annevk annevk requested a review from domenic May 5, 2020 17:54
@domenic
Copy link
Member

domenic commented May 5, 2020

I was thinking of the multiple rows approach. It's pretty common, e.g. something like it (in ASCII form) appears even in the RFCs.

@annevk
Copy link
Member Author

annevk commented May 5, 2020

https://tools.ietf.org/html/rfc3986#section-3 seems to be a table with the heading row in the middle, but doesn't have multiple heading rows, or is there another one I missed?

Anyway, I think someone else might have to take this then and figure out an aesthetic that works. The table form looked rather weird to me and having to use multiple tables for multiple examples seemed like a bit of an abuse of tables as well.

@domenic
Copy link
Member

domenic commented May 5, 2020

You're right, that's the one that I was thinking of.

Base automatically changed from master to main January 15, 2021 07:41
@annevk annevk closed this May 20, 2021
@annevk annevk deleted the annevk/URL-getters branch May 20, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants