Editorial: use an encode set in the query state #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I think there's a way to do this for application/x-www-form-urlencoded as well which will make it even clearer what is going on.) |
domenic
requested changes
May 11, 2020
annevk
force-pushed
the
annevk/string-utf-8-percent-encode
branch
from
6932e5b
to
bc67da4
Compare
annevk
force-pushed
the
annevk/query-encode-set
branch
from
ecc5bbf
to
252e1dc
Compare
domenic
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note that this depends on #503 landing first.)
@rmisev @domenic @mgiuca @mkgl what do you think? Worth doing?
Preview | Diff