Editorial: deduplicate the relative state #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps with #504.
|
(file state is very similar to this, but I'll tackle that in a separate PR for clarity and ease of reviewing.) |
domenic
approved these changes
May 11, 2020
| <var>url</var>'s <a for=url>path</a>'s last item, if any. | ||
| <li><p>Set <var>url</var>'s <a for=url>query</a> to null. | ||
|
|
||
| <li><p><a for=list>Remove</a> <var>url</var>'s <a for=url>path</a>'s last item, if any. | ||
|
|
||
| <li><p>Set <var>state</var> to <a>path state</a> and decrease <var>pointer</var> by 1. |
There was a problem hiding this comment.
Might want to split this into two steps while you're here.
There was a problem hiding this comment.
If we want to do that we should probably do that across the whole file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #504.
(I'll double check with whatwg-url that this is okay in a bit.)
Preview | Diff