Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named validation errors #514

Closed
wants to merge 1 commit into from
Closed

Conversation

annevk
Copy link
Member

@annevk annevk commented May 13, 2020

Closes #406.

@TRowbotham I took some time to rebase #502 (what helps a lot is squashing first) and I think it worked out, but I didn't want to overwrite your branch without checking with you.


Preview | Diff

@TRowbotham
Copy link
Contributor

Thanks for cleaning this up @annevk! Overwriting my branch is fine.

The only validation error that is missing a description and example is unexpected-windows-drive-letter-host. It is part of file host state step 1.1. I seem to be having a mental block on that one, so if anyone has an idea for that it would be great.

It would be good if someone did a sanity check on the error descriptions and examples too.

@rmisev
Copy link
Member

rmisev commented May 13, 2020

The only validation error that is missing a description and example is unexpected-windows-drive-letter-host. It is part of file host state step 1.1. I seem to be having a mental block on that one, so if anyone has an idea for that it would be great.

Description:
The file URL's host is a windows drive letter.

Example:
"file://c:"

@annevk
Copy link
Member Author

annevk commented May 14, 2020

Let's continue this in #502 now it's been rebased.

@annevk annevk closed this May 14, 2020
@annevk annevk deleted the annevk/validation-errors branch May 14, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Named validation errors
3 participants