Correct valid IPv4-address string #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A more ambitious take might be trying to share some infrastructure with HTML's valid non-negative integer... |
|
Though from a quick look at the HTML standard that would not prevent the issue with e.g. 01 being considered valid. This should do. I think this closes the issue. Thanks, also, since I suggested that I would get back to it and then didn’t. |
|
Right, we would still need to constrain it with "shortest possible", but that's also used within HTML to constrain things. Perhaps there is some future point where Infra defines more of this and we could refactor this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #583.
cc @alwinb
Preview | Diff