Ensure the API roundtrips for opaque paths #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As opaque paths can end in U+0020, those trailing U+0020 code points need to be removed from the path when both query and fragment become null. Tests: ... Fixes #651.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 16, 2022
This was referenced Dec 16, 2022
domenic
reviewed
Dec 22, 2022
There was a problem hiding this comment.
I might be missing something but I think to make web-platform-tests/wpt#37556 pass you need to modify the pathname setter as well. I'm getting data:space vs. data:nospace and sc:space vs. sc:nospace failures when I try to implement this in jsdom/whatwg-url.
|
Thanks, I first thought I indeed had to update the |
domenic
approved these changes
Dec 23, 2022
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 2, 2023
This was referenced Jan 2, 2023
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jan 3, 2023
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jan 3, 2023
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jan 3, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 5, 2023
…ue paths, a=testonly Automatic update from web-platform-tests URL: hash/search roundtripping with opaque paths For whatwg/url#728. -- wpt-commits: c8ad978c6ff0792e5bb29da0eff600b4ba18cc46 wpt-pr: 37556
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jan 13, 2023
…ue paths, a=testonly Automatic update from web-platform-tests URL: hash/search roundtripping with opaque paths For whatwg/url#728. -- wpt-commits: c8ad978c6ff0792e5bb29da0eff600b4ba18cc46 wpt-pr: 37556
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opaque paths can end in U+0020, those trailing U+0020 code points need to be removed from the path when both query and fragment become null.
Fixes #651.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff