Include last good version in caniuse boxes #39
Conversation
|
Arguably it should be grayed out if it is no longer supported in the last few versions... but maybe this is good enough @bbarenblat? |
|
I think if a feature is not supported in the latest version of a browser, that browser entry ought to be greyed out. That might be too labour-intensive, though. For instance, what if a feature is supported properly in the Firefox ESR but not in the latest release (due to a regression or dropped support)? The easiest way around this is probably to hook into Can I Use’s usage data and make the grey/black display reflect the most commonly used version. Is there support for that? I’d also prefer to keep the version+ notation for features that are supported up to the current version, because it doesn’t require readers to keep track of the current versions of every browser to see current support. |
|
So...
|
|
Yes, that’s right. |
|
It'd also be ideal to change "11-11" to just "11" while you're here :). Thanks for working on this @zcorpan!! |
|
It seems no other caniuse boxes have anything with "removed". @Hixie could you maybe review the code? |
| var | ||
| i: Integer; | ||
| begin | ||
| i := Pos(Separator, Txt); |
There was a problem hiding this comment.
This is expensive. I would use the rope stuff to do a no-copy splitter with a single walk.
There was a problem hiding this comment.
Specifically, I'd use the https://github.com/whatwg/wattsi/blob/master/src/lib/stringutils.pas stuff to iterate over the string, grab the start pointer and the middle pointer using a single walk, and return the two CutUTF8Strings.
But whatever. This code would work fine too.
There was a problem hiding this comment.
OK. Could you push a commit to do that? My guess is that it would take me hours to figure out how to use ropes...
There was a problem hiding this comment.
Just use whatever works. :-) Maybe drop a link to this review so that someone in the future can improve it if it turns out to be a bottleneck.
|
@domenic please merge and do the necessary manual steps (if we still have manual steps). 🙂 |
Fixes whatwg/html#2225.
...should probably also change "5.0-5.1-10-10.1" to just "5.0-10.1", but not knowing FreePascal it's not immediately obvious to me how to do so.