Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mixin [NoInterfaceObject] usage #430

Open
annevk opened this issue Sep 1, 2017 · 12 comments
Open

No mixin [NoInterfaceObject] usage #430

annevk opened this issue Sep 1, 2017 · 12 comments

Comments

@annevk
Copy link
Member

annevk commented Sep 1, 2017

Per #423 (comment) this exists. I'd like to study such usage and see if we can get rid of it.

@tobie
Copy link
Collaborator

tobie commented Sep 1, 2017

Here's a manually filtered list I build for #363 based on running awk on Gecko's src files:

  • Geolocation
  • Coordinates
  • Position
  • PositionError
  • DeviceAcceleration
  • DeviceRotationRate
  • ConstrainablePattern
  • WEBGL_compressed_texture_astc
  • WEBGL_compressed_texture_s3tc_srgb
  • WEBGL_draw_buffers.
  • WEBGL_lose_context
  • ANGLE_instanced_arrays
  • EXT_blend_minmax
  • EXT_color_buffer_float
  • EXT_disjoint_timer_query
  • OES_standard_derivatives
  • OES_vertex_array_object.

@annevk
Copy link
Member Author

annevk commented Sep 1, 2017

Thanks, seems like we could just drop the keyword from those and be done with it. I guess part of the problem is some of those specifications not being maintained, but that can be fixed one way or another.

@tobie
Copy link
Collaborator

tobie commented Sep 1, 2017

Well, we'd want to make sure suddenly exposing these interfaces to the Web doesn't break stuff, no?

@annevk
Copy link
Member Author

annevk commented Sep 1, 2017

Yeah, I suppose the ones with overly generic names should be prefixed, but seems safe otherwise.

@tobie
Copy link
Collaborator

tobie commented Sep 1, 2017

Prefixing is an observable change. No idea if it would have real impact, though.

@annevk
Copy link
Member Author

annevk commented Sep 1, 2017

How is it observable?

@tobie
Copy link
Collaborator

tobie commented Sep 1, 2017

navigator.geolocation.getCurrentPosition(p => console.log(Object.prototype.toString.call(p)));
// [object Position]

@annevk
Copy link
Member Author

annevk commented Sep 1, 2017

Sigh. Part of the reason we had [NoInterfaceObject] was the ability to ship objects and change the name later. I guess that's another reason we should really get rid of it (and decide on names we can live with upfront).

@annevk
Copy link
Member Author

annevk commented Jan 15, 2019

WebGL seems fixed. I filed issues against two other specifications I identified from the list above. Anything else?

@domenic
Copy link
Member

domenic commented Jan 15, 2019

Searching through Blink, External in the HTML spec needs fixing. There's also w3c/mediacapture-main#501 which is weird.

@domenic
Copy link
Member

domenic commented Jan 15, 2019

Also https://w3c.github.io/webappsec-feature-policy/#featurepolicy ... a little hard to tell since Blink doesn't have interface mixin syntax yet, so lots of stuff is mixed together.

annevk added a commit to whatwg/html that referenced this issue Jan 15, 2019
Hiding interface objects is no longer a thing the web platform does.

Helps with whatwg/webidl#430.
@bzbarsky
Copy link
Collaborator

Fwiw, that's why I haven't looked at this in Gecko either. It'll be a lot simpler once we implement mixin syntax...

annevk added a commit to whatwg/html that referenced this issue Jan 16, 2019
Hiding interface objects is no longer a thing the web platform does.

Helps with whatwg/webidl#430.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
Hiding interface objects is no longer a thing the web platform does.

Helps with whatwg/webidl#430.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
Hiding interface objects is no longer a thing the web platform does.

Helps with whatwg/webidl#430.
@annevk annevk removed the enhancement label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants