Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [NoInterfaceObject]. #609

Closed
wants to merge 1 commit into from
Closed

Remove [NoInterfaceObject]. #609

wants to merge 1 commit into from

Conversation

Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented Jan 14, 2019

Fixes #430.


Preview | Diff

@domenic
Copy link
Member

domenic commented Jan 14, 2019

I guess the real work here is PRing every spec that uses it, and then trying to ship and see if the result is web-compatible...

@Ms2ger
Copy link
Member Author

Ms2ger commented Jan 15, 2019

Indeed. I'm not sure if all the specs that use it are maintained, though. Perhaps one of the browser vendors should try shipping first and see what happens.

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Jan 28, 2019
@jan-ivar
Copy link
Contributor

https://w3c.github.io/mediacapture-main/#interface-definition (@aboba @jan-ivar)

"Although this specification formally defines ConstrainablePattern as a WebIDL interface, it is actually a template or pattern for other interfaces and cannot be inherited directly since the return values of the methods need to be extended,", so 👍

@foolip
Copy link
Member

foolip commented Feb 14, 2019

Ah, sounds like that interface should be marked up as an example in the spec. This would avoid it showing up in reffy-reports, and would avoid the need for [NoInterfaceObject], which presumably isn't something the other interfaces should copy.

@jan-ivar
Copy link
Contributor

@foolip How do I do that?

@foolip
Copy link
Member

foolip commented Feb 14, 2019

@jan-ivar wrapping in <div class="example"> might to the trick. Or if you want to just avoid it being extracted by reffy, the exclude class was added in w3c/reffy#137 for that purpose.

@saschanaz
Copy link
Member

saschanaz commented Oct 3, 2019

Are there still known blockers other than w3c/webappsec-permissions-policy#341 or is it the last one?

Edit: WebGL is still using NoInterfaceObject a lot https://github.com/KhronosGroup/WebGL/search?q=nointerfaceobject&unscoped_q=nointerfaceobject

@bzbarsky
Copy link
Collaborator

bzbarsky commented Oct 3, 2019

Well, there's the fact that as far as I know browsers haven't shipped the removals done so far, so we don't know whether they're web-compatible, right?

@saschanaz
Copy link
Member

Yes, although at least some of them are shipped in stable Chrome e.g. External from HTML and DeviceMotionEventRotationRate etc. from device orientation.

@domenic
Copy link
Member

domenic commented Aug 2, 2021

We renamed it to [LegacyNoInterfaceObject] and all remaining uses are in Web GL. If Web GL shows signs of wanting to expose their interfaces then we can revisit, but for now let's close...

@domenic domenic closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Pull request must not be merged per rationale in comment
Development

Successfully merging this pull request may close these issues.

No mixin [NoInterfaceObject] usage
6 participants