-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn Web IDL into a Living Standard #1018
Conversation
A thing I did not realize is that Web IDL has some Node.js-based post processing as well. It's not clear to me if spec-factory's |
I essentially added
to the I ended up suppressing RFC2119 warnings. Given that "optional" is a term that's frequently used that ended up generating too much noise (I suspect "required" as well, but I didn't get that far). |
See whatwg/webidl#1018 for context.
The default WHATWG boilerplate includes an entry in the spec metadata section that links to the WPT tests, and I noticed that for Web IDL, the WPT folder it links to is |
Really appreciate your help with this @andreubotella! @domenic want to take a look? @TimothyGu you might also be interested? |
|
||
deploy: index.bs | ||
curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh | ||
POST_BUILD_STEP='node ./check-grammar.js "$$DIR/index.html" && npm run pp-webidl -- --input "$$DIR/index.html"' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does $$DIR
come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's passed in as an argument. Encoding does the same thing.
@@ -532,7 +476,7 @@ in [[#es-extended-attributes]]. | |||
IncludesStatement | |||
</pre> | |||
|
|||
<div class="example"> | |||
<div class="example" id="example-25f60a7c"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we give these examples real IDs? I care about this a good bit so if you can't be bothered I guess I'll volunteer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the current IDs, for better or worse. I guess I don't feel too strongly about keeping these IDs working, but folks might be linking to them. (I haven't checked, but either this is disabled or Bikeshed must generate a lot of warnings for the document in its current state.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that turns this from a "we should fix before merging" to a "we should maybe fix eventually".
This also makes factory.py more useful for a single standard. See whatwg/webidl#1018 for context.
Helps with #1016.
Closes #955.
Alright, the first deploy worked! |
Helps with #1016.
💥 Error: 400 Bad Request 💥
PR Preview failed to build. (Last tried on Sep 3, 2021, 2:15 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.