Clarify #named-properties-object #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Mar 29, 2023
|
Thanks @domenic, could you please commit on my behalf? I don’t think I have the right permissions. |
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Mar 29, 2023
Closes #9068, in conjunction with whatwg/webidl#1285.
|
I did ask in web-platform-tests/wpt#36746 (comment) why we want this behaviour, but I never got an answer. |
|
I suspect nobody really knows? But also that adding it might have some risk associated with it? |
|
Note that it's the behaviour that Gecko has had all along (because we think/thought that returning something from |
|
I don't have a strong opinion on this. If you want others to consider the Gecko behavior file a new issue? Main potentially problematic things I can think of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch clarifies #named-properties-object per whatwg/html#9068 by adding a note that reads
The use of “real” in scare quotes is based on the wording in #es-legacy-platform-objects, but I’m open to suggestions for a more precise wording if needed.
Preview | Diff