Base sequences, dictionaries, and records on Infra types #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes whatwg/infra#4 and whatwg/infra#65. It also helps a bit with #242.
jyasskin
reviewed
Feb 22, 2017
index.bs
Outdated
| @@ -4104,6 +4107,10 @@ the value to use for the dictionary member when passing a value to a | |||
| not have a specified value. Dictionary members with default values are | |||
| always considered to be present. | |||
|
|
|||
| An [=ordered map=] with string [=map/keys=] can be implicitly treated as a dictionary value of a | |||
| specific dictionary |D| if all of its [=map/entries=] correspond to dictionary members, in the | |||
There was a problem hiding this comment.
Do you want to also enforce required fields here?
| @@ -5662,7 +5669,10 @@ identifies a [=dictionary=] is used to refer to | |||
| a type that corresponds to the set of all dictionaries that adhere to | |||
| the dictionary definition. | |||
|
|
|||
| There is no way to represent a constant dictionary value in IDL. | |||
| The literal syntax for [=ordered maps=] may also be used to represent dictionaries, when it is | |||
index.bs
Outdated
| @@ -5792,22 +5804,20 @@ The [=type name=] of a sequence type | |||
| is the concatenation of the type name for |T| and | |||
| the string “Sequence”. | |||
|
|
|||
| Any [=list=] can be implicitly treated as a sequence, as long as it contains only [=list/items=] | |||
There was a problem hiding this comment.
Maybe "… as a sequence<T>, … that are of type T."?
index.bs
Outdated
| However, there is no way to represent a constant record value in IDL. | ||
| A <dfn export>record type</dfn> is a parameterized type whose values are [=ordered maps=] with | ||
| [=map/keys=] that are instances of |K| and [=map/values=] that are instances of |V|. |K| must be one | ||
| of {{DOMString}}, {{USVString}}, or {{ByteString}}. The order of a record's [=map/entries=] is |
There was a problem hiding this comment.
We can probably drop the "The order of a record's entries ..." sentence now. I feel like that's obvious from it being an ordered map.
index.bs
Outdated
| @@ -5822,6 +5832,11 @@ Records must not be used as the type of an [=attribute=] or | |||
| The [=type name=] of a record type is the concatenation of the type | |||
| name for |K|, the type name for |V| and the string “Record”. | |||
|
|
|||
| Any [=ordered map=] can be implicitly treated as a record, as long as it contains only | |||
There was a problem hiding this comment.
Similar to sequence, as a record<K, V>` might be clearer, and might let you omit the "Additionally..." sentence since the restriction on K was already stated above.
index.bs
Outdated
| @@ -7415,17 +7430,17 @@ ECMAScript <emu-val>Object</emu-val> values. | |||
| [=ECMAScript/throw=] a <emu-val>TypeError</emu-val>. | |||
| 1. Let |result| be a new empty instance of <code>[=record=]<|K|, |V|></code>. | |||
| 1. Let |keys| be [=?=] |O|.\[[OwnPropertyKeys]](). | |||
| 1. Repeat, for each element |key| of |keys| in [=List=] order: | |||
| 1. Repeat, [=list/for each=] element |key| of |keys|: | |||
|
@jyasskin addressed your feedback. Great call on the |
jyasskin
approved these changes
Feb 22, 2017
tobie
reviewed
Feb 22, 2017
index.bs
Outdated
| @@ -7415,17 +7429,17 @@ ECMAScript <emu-val>Object</emu-val> values. | |||
| [=ECMAScript/throw=] a <emu-val>TypeError</emu-val>. | |||
| 1. Let |result| be a new empty instance of <code>[=record=]<|K|, |V|></code>. | |||
| 1. Let |keys| be [=?=] |O|.\[[OwnPropertyKeys]](). | |||
| 1. Repeat, for each element |key| of |keys| in [=List=] order: | |||
| 1. [=list/For each=] element |key| of |keys|: | |||
There was a problem hiding this comment.
- [=list/For each=] |key| of |keys|:
|
Best commit message ever. :) Can I merge this or are you waiting for @annevk's feedback? |
|
I think we should be good to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes whatwg/infra#4 and whatwg/infra#65. It also helps a bit with #242.
/cc @jyasskin @annevk
Preview | Diff