-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert-policy.py and Markdown #291
Comments
I think Commonmark is worth a lot just in being the same as GitHub and helping the Markdown ecosystem converge toward a single spec. |
Could it be that the Python
or
whereas if I try that locally with the |
That could be possible, if distressing :(. Although as I noted in whatwg/sg#92 (comment) I'm unsure why our input contains |
That's what convert-policy does. We could possibly change it to do post-HTML-conversion changes. That would also fix #145. But I don't think I've really seen where commonmark and markdown give different results yet. Other than that commonmark didn't do email address auto-linking. (Perhaps it needs to be wrapped inside angle brackets.) |
from mdx_partial_gfm import PartialGithubFlavoredMarkdownExtension
appears to be the auto-linking of the email address in the Code of Conduct. We could consider replacing it with something simpler that handles email addresses.commonmark
would require some restructuring of the code as it doesn't like some of the pre-processing we do. It ends up wrapping our headings with paragraphs and also encodes a bunch of " as"
.It's not clear that making either is worth it.
The text was updated successfully, but these errors were encountered: