-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split build/ into its own repository? #71
Comments
I think the idea was to not rely on GitHub for hosting, or at least not rely on raw.githubusercontent.com. But, I'm not sure how important that is. |
Hmm, so the deploy script itself relies on https://api.github.com/repos/whatwg/whatwg.org/contents/resources.whatwg.org/standard-service-worker.js being available, so it's already somewhat entangled. But if gratuitous entanglement is worth avoiding, just leaving this alone would be OK. Finding the script is not super easy now, but I guess the script could point to where it is on GitHub? |
I think it's fine to rely on GitHub for hosting for content that's not viewed by end users. I.e., stuff we could move elsewhere without disruption. |
So, I can do this if you think it makes sense. Bikeshed on the name? |
common-build seems fine, given html-build precedent. |
I've created https://github.com/whatwg/common-build with a linear history that matches exactly what's at the tip of this repo now. Can you review it? |
Looks good. |
OK, so I've cloned all whatwg repos and grepped around, this is the remaining work:
|
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty,
Part of whatwg/whatwg.org#71. Also fix the README.md, the local deploy.sh is gone.
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
OK, I've done about half of what needs to be done. Will stop here to see if there's some serious flaw before doing the second half. |
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
Part of whatwg/whatwg.org#71. Also fix the README.md, the local deploy.sh is gone.
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
Part of whatwg/whatwg.org#71. Also require the dist to be Trusty.
Having gotten a fair bit on the way with these changes, I'm coming around to the wisdom of this. The rate limiting I ran into in https://github.com/whatwg/common-build/issues/2 was for api.github.com, but raw.githubusercontent.com might also be rate limited. I found microsoft/vscode#3708 suggesting that others have had trouble with this. So... I'm leaning towards abandoning all of these changes and instead:
Any other considerations? |
Sounds good. Thanks a lot for finding the source! |
I've moved over the issue/PR and made https://github.com/whatwg/common-build private, should delete it before closing this issue. |
OK, all PRs closed, but opened new PRs for some of the drive-bys I had done. Deleting common-build and closing this issue. |
AFAICT there's no particular reason that https://github.com/whatwg/whatwg.org/tree/master/resources.whatwg.org/build needs to be deployed to a web server, we could curl it from https://raw.githubusercontent.com/whatwg/whatwg.org/master/resources.whatwg.org/build/deploy.sh.
Given that, should we just put it in a separate repository? whatwg-build? common-build?
@annevk @domenic
The text was updated successfully, but these errors were encountered: