Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split build/ into its own repository? #71

Closed
foolip opened this issue Aug 29, 2017 · 13 comments
Closed

Split build/ into its own repository? #71

foolip opened this issue Aug 29, 2017 · 13 comments

Comments

@foolip
Copy link
Member

foolip commented Aug 29, 2017

AFAICT there's no particular reason that https://github.com/whatwg/whatwg.org/tree/master/resources.whatwg.org/build needs to be deployed to a web server, we could curl it from https://raw.githubusercontent.com/whatwg/whatwg.org/master/resources.whatwg.org/build/deploy.sh.

Given that, should we just put it in a separate repository? whatwg-build? common-build?

@annevk @domenic

@domenic
Copy link
Member

domenic commented Aug 29, 2017

I think the idea was to not rely on GitHub for hosting, or at least not rely on raw.githubusercontent.com. But, I'm not sure how important that is.

@foolip
Copy link
Member Author

foolip commented Aug 29, 2017

Hmm, so the deploy script itself relies on https://api.github.com/repos/whatwg/whatwg.org/contents/resources.whatwg.org/standard-service-worker.js being available, so it's already somewhat entangled.

But if gratuitous entanglement is worth avoiding, just leaving this alone would be OK. Finding the script is not super easy now, but I guess the script could point to where it is on GitHub?

@annevk
Copy link
Member

annevk commented Aug 30, 2017

I think it's fine to rely on GitHub for hosting for content that's not viewed by end users. I.e., stuff we could move elsewhere without disruption.

@foolip
Copy link
Member Author

foolip commented Aug 30, 2017

So, I can do this if you think it makes sense. Bikeshed on the name?

@annevk
Copy link
Member

annevk commented Aug 30, 2017

common-build seems fine, given html-build precedent.

@foolip
Copy link
Member Author

foolip commented Aug 30, 2017

I've created https://github.com/whatwg/common-build with a linear history that matches exactly what's at the tip of this repo now. Can you review it?

@annevk
Copy link
Member

annevk commented Aug 30, 2017

Looks good.

@foolip
Copy link
Member Author

foolip commented Aug 30, 2017

OK, so I've cloned all whatwg repos and grepped around, this is the remaining work:

foolip added a commit to whatwg/fullscreen that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/compat that referenced this issue Aug 30, 2017
Part of whatwg/whatwg.org#71.

Also fix the README.md, the local deploy.sh is gone.
foolip added a commit to whatwg/fullscreen that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/fullscreen that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/dom that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/infra that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/fetch that referenced this issue Aug 30, 2017
@foolip
Copy link
Member Author

foolip commented Aug 30, 2017

OK, I've done about half of what needs to be done. Will stop here to see if there's some serious flaw before doing the second half.

foolip added a commit to whatwg/fullscreen that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/compat that referenced this issue Aug 30, 2017
Part of whatwg/whatwg.org#71.

Also fix the README.md, the local deploy.sh is gone.
foolip added a commit to whatwg/dom that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/infra that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/fetch that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/dom that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/mimesniff that referenced this issue Aug 30, 2017
foolip added a commit to whatwg/notifications that referenced this issue Aug 30, 2017
@foolip
Copy link
Member Author

foolip commented Aug 30, 2017

I think the idea was to not rely on GitHub for hosting, or at least not rely on raw.githubusercontent.com. But, I'm not sure how important that is.

Having gotten a fair bit on the way with these changes, I'm coming around to the wisdom of this. The rate limiting I ran into in https://github.com/whatwg/common-build/issues/2 was for api.github.com, but raw.githubusercontent.com might also be rate limited. I found microsoft/vscode#3708 suggesting that others have had trouble with this.

So... I'm leaning towards abandoning all of these changes and instead:

Any other considerations?

@annevk
Copy link
Member

annevk commented Aug 31, 2017

Sounds good. Thanks a lot for finding the source!

@foolip
Copy link
Member Author

foolip commented Aug 31, 2017

I've moved over the issue/PR and made https://github.com/whatwg/common-build private, should delete it before closing this issue.

@foolip
Copy link
Member Author

foolip commented Aug 31, 2017

OK, all PRs closed, but opened new PRs for some of the drive-bys I had done. Deleting common-build and closing this issue.

@foolip foolip closed this as completed Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants