Styling hgroup p #408
Merged
Styling hgroup p #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2022
Closed
|
I think this is good now. Indeed it seems like our heading styles are kind of a mess and could be cleaned up a good bit, but, let's leave that for later... |
annevk
commented
Nov 7, 2022
| .head h1 { margin: 0 100px 0 0; } | ||
| hgroup p { margin: 0 100px 1em 0; } | ||
| hgroup p, .head h2 { margin: 0 100px 1em 0; } |
There was a problem hiding this comment.
Does .head h2 still exist then?
There was a problem hiding this comment.
Hmm, seems unlikely, not sure why I did that...
|
This looks good to me, but @domenic you'll have to approve it due to GitHub not being able to figure out who did the majority of the work... |
domenic
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #401.
@domenic this sorta does the thing, but I haven't tested it and it could certainly be organized better. Though some of this was already a mess with sometimes using
.headand sometimeshgroup(as far as I can tell that comes down to the same thing).Probably also want to look at the style inspector to make sure there's not a lot of rules getting dropped and such.