Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "form data set" with "entry list" to follow an HTML specifica… #210

Merged
merged 1 commit into from
May 28, 2018
Merged

Replace "form data set" with "entry list" to follow an HTML specifica… #210

merged 1 commit into from
May 28, 2018

Conversation

tkent-google
Copy link
Contributor

@tkent-google tkent-google commented May 23, 2018

…tion change.

This is a part of whatwg/html#3676


Preview | Diff

@tkent-google
Copy link
Contributor Author

This patch produces:

  • [HTML] defines the following terms:
    • ...
    • constructing the form data set

in "Terms defined by reference" section though it should be "constructing the entry list". How to fix it?

xhr.bs Outdated
@@ -1792,7 +1792,8 @@ constructor must run these steps:
<li><p>Let <var>fd</var> be a new {{FormData}} object.

<li><p>If <var>form</var> is given, then set <var>fd</var>'s <a for=FormData>entry list</a> to the
result of <a>constructing the form data set</a> for <var>form</var>.
result of <a lt="constructing the form data set">constructing the entry list</a> for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this <a>constructing the entry list</a>. This'll fail until we've updated HTML with the new term and approximately one day has passed so the cross-specification indexes have had time to update. After that we can double check and it should be okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks!

annevk pushed a commit to whatwg/html that referenced this pull request May 25, 2018
Also use File objects for entry values rather than an abstraction.

Corresponding XMLHttpRequest Standard change: whatwg/xhr#210.

Fixes part of #3676.
@annevk
Copy link
Member

annevk commented May 25, 2018

We should also remove

For the purposes of interaction with other algorithms, an entry’s filename is the empty string if value is not a File object, and otherwise its filename is the value of entry’s value’s name attribute.

now, right?

@tkent-google
Copy link
Contributor Author

We should also remove ... now, right?

I think the paragraph is still necessary for RFC7578, and application/x-www-form-urlencoded serializer.

@annevk annevk merged commit 5e7cb0a into whatwg:master May 28, 2018
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
Also use File objects for entry values rather than an abstraction.

Corresponding XMLHttpRequest Standard change: whatwg/xhr#210.

Fixes part of whatwg#3676.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants