Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a no_wait_for_reply option to Redix.command/pipeline #87

Closed
wants to merge 1 commit into from

Conversation

SimonWoolf
Copy link

Fixes #85

Planning to use this for an application that will have a very high rate of of key writes (where the application doesn't care enough to do anything if any of them fail) -- doesn't seem much point spending resources having redis respond to each one and redix diligently matching the reply to the request when I'll be ignoring the response anyway.

@whatyouhide
Copy link
Owner

Hey @SimonWoolf, thanks a lot for the work. I am planning to restructure some parts of Redis and I think this implementation is not the best one to go with especially because we're not taking care of CLIENT REPLY OFF (which means that if you want no replies, you'd have to send CLIENT REPLY SKIP everytime making it very inefficient). I'll use your code as reference when implementing this though, so thanks so much for the contribution! 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants