Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accuraterip-checksum #362

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Conversation

Freso
Copy link
Member

@Freso Freso commented Feb 11, 2019

Version 1.5 was released back in June and has a fix to work on 32-bit platforms (contributed by @MerlijnWajer).

@Freso Freso changed the base branch from master to develop February 11, 2019 17:31
@Freso Freso force-pushed the update-accuraterip-checksum branch from c12d991 to c1ac579 Compare February 11, 2019 17:32
@Freso Freso force-pushed the update-accuraterip-checksum branch from e422e0e to fabd50d Compare February 11, 2019 17:57
@MerlijnWajer
Copy link
Collaborator

Looks good to me (once all checks pass)

@JoeLametta
Copy link
Collaborator

Thanks for the pull request!

@Freso should we update this section of the README? (and/or add it to the list of required dependencies? - in case the right version is already packaged)

@Freso
Copy link
Member Author

Freso commented Feb 11, 2019

should we update this section of the README?

I didn't update the Makefile to be the one from upstream (only the .c and README.md files), so there are no changes to those instructions AFAIK. (The .travis.yml works fine without alterations anyway.)

If it needs to be listed in dependencies or not is a question outside the scope of this PR I think, and I have no strong opinion either way currently. :)

@JoeLametta JoeLametta merged commit 9524289 into develop Feb 11, 2019
@JoeLametta JoeLametta deleted the update-accuraterip-checksum branch February 11, 2019 18:45
@JoeLametta
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants