-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include MusicBrainz Release URL in log output #382
Include MusicBrainz Release URL in log output #382
Conversation
You might want to add |
@MerlijnWajer But there's nothing there getting the metadata? |
This also passes *all* metadata to the `result` object, giving loggers a lot more (release) metadata to work with, in case custom, “3rd party” loggers (or even ourselves in the future!) want to do something more fancy or expansive with the metadata in the log file. Fixes #381 Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
dd3d59d
to
a758ea5
Compare
@MerlijnWajer Done. :) |
Sample
|
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Merged, thanks! |
This also passes all metadata to the
result
object, giving loggers a lot more (release) metadata to work with, in case custom, “3rd party” loggers (or even ourselves in the future!) want to do something more fancy or expansive with the metadata in the log file.Fixes #381