Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize kerkoapp #6

Merged
merged 14 commits into from
Jul 24, 2019
Merged

Dockerize kerkoapp #6

merged 14 commits into from
Jul 24, 2019

Conversation

retorquere
Copy link
Contributor

No description provided.

@retorquere retorquere mentioned this pull request Jul 22, 2019
Closed
davidlesieur
davidlesieur requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@davidlesieur davidlesieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. It will be awesome to have a ready to use Docker container. I am submitting some suggestions and questions. Later on, it will also be useful to document this in the README file.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
dotenv.sample Outdated Show resolved Hide resolved
dotenv.sample Outdated Show resolved Hide resolved
dotenv.sample Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
@retorquere
Copy link
Contributor Author

BTW I've set my name as maintainer but I don't mind that being changed.

@davidlesieur davidlesieur added the enhancement New feature or request label Jul 24, 2019
@davidlesieur
Make run the default target.
7c08fe5
@davidlesieur
Avoid changing the Git repo on make publish. Make sure tags do not cl…
f8b5603 
…ash.
@davidlesieur
Add some metadata upon build.
d0a3521 
Some background:

- The MAINTAINER Docker instruction is deprecated.
- The metadata schema is based on https://github.com/opencontainers/image-spec/blob/master/annotations.md.
- Using the 'maintainer' key (which is not part of the above schema) because otherwise its value is inherited from the base image.
@davidlesieur
Copy link
Member

I have pushed a few more changes. I'll wait before merging the PR, in case you have comments. Thanks!

@retorquere
Copy link
Contributor Author

I've been following, looks good to me.

@davidlesieur davidlesieur merged commit 0c0562d into whiskyechobravo:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlesieur davidlesieur davidlesieur requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retorquere @davidlesieur