This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
fix scrolling after zoom #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemnoel
approved these changes
Nov 12, 2021
philippemnoel
pushed a commit
that referenced
this pull request
Dec 1, 2021
schkillten
pushed a commit
that referenced
this pull request
Dec 24, 2021
schkillten
pushed a commit
that referenced
this pull request
Dec 24, 2021
schkillten
pushed a commit
that referenced
this pull request
Jan 3, 2022
fhvwy
pushed a commit
that referenced
this pull request
Apr 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that after rapid zooming, SDL never gets a pinch event from macOS with a magnification of 0 -- the last tick has nonzero magnification. Hence, the protocol never believes the zoom event has ended, and all scrolling is disabled until a successful zoom cancellation!
This PR fixes things by explicitly checking for whether a pinch event is closing out a pinch action, in which case we force the magnification to 0 so that the protocol can now appropriately handle.