Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock #21

Merged
merged 4 commits into from
Aug 12, 2016
Merged

Clock #21

merged 4 commits into from
Aug 12, 2016

Conversation

keawade
Copy link
Collaborator

@keawade keawade commented Aug 12, 2016

left-pad dependency removed. 🎉

Resolves #14. See #8.

@keawade
Copy link
Collaborator Author

keawade commented Aug 12, 2016

Finally got back to it. @NathanBland, I think this resolves your concerns?

@@ -57,6 +57,7 @@
"karma-sourcemap-loader": "^0.3.7",
"karma-spec-reporter": "0.0.24",
"karma-webpack": "^1.7.0",
"left-pad": "^1.1.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still here 😉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I get for trusting npm to remove it for me.

@NathanBland
Copy link
Collaborator

That's more like it! 👍

I still don't get why you didn't use toLocaleTimeString, but whatever floats your boat. I'll merge this in.

@NathanBland NathanBland merged commit a7cfee8 into whiteboards:master Aug 12, 2016
@NathanBland NathanBland mentioned this pull request Aug 12, 2016
3 tasks
@keawade
Copy link
Collaborator Author

keawade commented Aug 12, 2016

What I had worked and I was approximately two weeks behind on getting this in haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants