Fixes a few issues #190
Closed
Fixes a few issues #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the passed in buffer is smaller than the "len" argument, fix the len argument
Need to see if we are allowed to write to the can fifo TODO: either make it interrupt driven, or at least do an os context switch spin-loop's are BAD
Move setup to top and then only use the config values and not the #defined ones
Now you can select any pin for the can interface
jolivepetrus
force-pushed
the
master
branch
2 times, most recently
from
f53ce16
to
02ee91e
Compare
|
@thilo-hub I've included your fix for data including zeroes |
|
We close this PR, because this other PR (#267) has been merged to master. Please, review if your problem is still present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.