rework CAN to use esp-idf functionality #267
Conversation
|
This new CAN implementation turns out to work really well. Is there any test script for testing CAN networking? I got two ESP32-EVB devices with CAN that I could wire together. Anything I need to be aware of with regards to CAN networking? |
|
I will focused again on CAN shortly. |
|
fantastic - let me know whenever I can help |
added cpu.h required for CPU_FIRST_CAN and CPU_LAST_CAN
| @@ -65,6 +65,7 @@ | |||
| #include <sys/mutex.h> | |||
|
|
|||
| #include <drivers/can.h> | |||
| #include <drivers/cpu.h> | |||
There was a problem hiding this comment.
now required for CPU_FIRST_CAN and CPU_LAST_CAN
make sure we won't block forever if * the can-bus is buggy/gone * resp. the queue is full does properly to auto-recover once the bus is back
|
after having done quite some testing / using the CAN-bus, |
components/sys/drivers/can.c
Outdated
| can_start(); //make sure can is running | ||
| can_initiate_recovery(); //make sure the bus is on |
There was a problem hiding this comment.
these calls should not be performed on every send so I have moved them to the error-case only
components/sys/drivers/can.c
Outdated
| can_start(); //make sure can is running | ||
| can_initiate_recovery(); //make sure the bus is on | ||
|
|
There was a problem hiding this comment.
these calls should not be performed on every send so I have moved them to the error-case only
|
Hi Thomas, I'm working again with CAN on ESP32. Testing this PR with my current CAN nodes HW test, based on PIC18FK MCU doesn't work as expected. Example code: -- Attach CAN at 500 Kbps speed -- Send a message PIC18FK MCU nodes don't respond to the sended CAN message. May be something related to 500 Kbps? |
|
Ok, I see the problem. In current implementation: https://github.com/whitecatboard/Lua-RTOS-ESP32/wiki/CAN-module speed is expressed in bits/sec, but in your implementation it's expressed in Kbps. No problem, I will change the wiki, it's more clear to express speed in Kbps. Thanks. |
only limited testing was posible.
please especially verify that CAN networking still works as expected!