Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Minisat and model enumeration algorithm #72

Merged
merged 6 commits into from
Jun 7, 2020

Conversation

marcofavorito
Copy link
Member

@marcofavorito marcofavorito commented Jun 3, 2020

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #72 into develop will increase coverage by 0.50%.
The diff coverage is 54.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
+ Coverage    38.73%   39.23%   +0.50%     
===========================================
  Files           54       55       +1     
  Lines         2290     2202      -88     
  Branches      1151     1097      -54     
===========================================
- Hits           887      864      -23     
+ Misses         691      658      -33     
+ Partials       712      680      -32     
Flag Coverage Δ
#unittests 39.23% <54.21%> (+0.50%) ⬆️
Impacted Files Coverage Δ
lib/include/lydia/basic.hpp 88.00% <ø> (ø)
lib/include/lydia/pl/cnf.hpp 25.00% <ø> (+18.75%) ⬆️
lib/include/lydia/to_dfa/strategies/sat.hpp 0.00% <ø> (ø)
lib/src/pl/eval.cpp 75.00% <ø> (ø)
lib/src/pl/logic.cpp 45.51% <ø> (ø)
lib/src/to_dfa/nfa_state.cpp 41.66% <ø> (ø)
lib/src/to_dfa/strategies/naive.cpp 42.37% <0.00%> (ø)
lib/src/to_dfa/strategies/sat.cpp 0.00% <0.00%> (ø)
lib/include/lydia/pl/models/base.hpp 50.00% <50.00%> (ø)
lib/include/lydia/pl/models/naive.hpp 50.00% <50.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0553348...cae62ab. Read the comment docs.

@marcofavorito marcofavorito merged commit 8956554 into develop Jun 7, 2020
@marcofavorito marcofavorito deleted the feature/minisat branch November 1, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant