Update Supervision instructions and specifications

[maikelthedev]

Hi, I'm trying to implement Eternal but I get deprecation errors because of this line

supervisor(Eternal, [:cart_item_lookup, [ :compressed ], [ quiet: true ]]),

asi in here

this is the error

Supervisor.Spec.supervisor/2 is deprecated. Use the new child specifications outlined in the Supervisor module insteadElixir

if I remove supervisor and start it as pointed in the docs of supervisor like this

{Eternal, [:cart_item_lookup, [ :compressed ], [ quiet: true ]]},

it has another error that it is not a child process or something like that.

This has been changed for a long time apparently since Elixir 1.5 and we're on 1.7, can this somehow be re-descirbed on the README or docs as to how to implement it without errors?

[maikelthedev]

Using this instead seems to work

      %{
        id: Eternal,
        start: {Eternal, :start_link, [:cart_item_lookup, [:compressed], [quiet: true]]}
      },

If the README.md and documentation could be updated, that would be great.

[whitfin]

Hi @maikelthedev!

You're right; this library has been largely unchanged going back to v1.5 (it's small+feature complete), so the instructions were outdated. I've updated this in the README, but I'm going to leave this issue open because there are some other improvements I can make in the library itself for the new Supervision setup.

Thank you for filing this issue 🎉

[maikelthedev]

thank you @whitfin