Redirect to run page on errors #611
Conversation
There was a problem hiding this comment.
Works as advertised 👍 LGTM
I am also seeing the duplicate error modal without copy + run, the normal create/compose error modal also seems to exhibit this behavior, but seems innocuous enough
EDIT: I've added an ID to the error modal in those 2 templates... This should hopefully prevent or at least hide the duplicate modal issue. This is because an ID selector only grabs the first match, where a Class selector returns all matches. Note that the duplicate modals are still attached to the DOM, but are never displayed to the user if an ID selector is used.
| @@ -31,7 +32,12 @@ export default Component.extend({ | |||
| let handleLaunchError = (tale, err) => { | |||
| console.error('Failed to launch Tale', err); | |||
| self.set("errorMessage", err.message); | |||
| $('.ui.modal.compose-error').modal('show'); | |||
| $('.ui.modal.compose-error').modal({ | |||
There was a problem hiding this comment.
Typo here - should have been copy-error... but instead of that, let's change it to an ID to prevent the duplicate modal from showing:
| $('.ui.modal.compose-error').modal({ | |
| $('#copy-error-modal').modal({ |
This should fix the duplicate modal issue for the copy-on-launch error case
| @@ -150,14 +150,12 @@ export default Component.extend({ | |||
| const self = this; | |||
| self.set("creatingTale", false); | |||
| self.handleError(e); | |||
| $('.ui.modal.compose-error').modal('show'); | |||
| $('.ui.modal.compose-error').modal({ | |||
There was a problem hiding this comment.
| $('.ui.modal.compose-error').modal({ | |
| $('#compose-error-modal').modal({ |
This should fix the duplicate modal issue for the create-tale / AiWT error cases
Redirects the user to the Tale if there is an error launching the Tale. This behaviour was built into the create-tale-modal, but we were showing the modal before loading this behavior.
This is a fix for #597 . After navigating to the run page and back the browse, users should see their Tale
Test Steps:
Side Note: I found another duplicate modal issue. After viewing the run page and going back to browse... If you copy + launch again you'll get two error modals.