Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize docs_href with currently selected resource_server. Fixes #616 #619

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Customize docs_href with currently selected resource_server. Fixes #616 #619

merged 1 commit into from
Mar 11, 2020

Conversation

Xarthisius
Copy link
Contributor

How to test?

  1. Deploy this and make sure you're running latest girder_wholetale cause I sneaked in Update DV's docs_href girder_wholetale#408
  2. Navigate to https://dashboard.local.wholetale.org/settings and click "connect" next to Dataverse.
  3. Link ("Get from Dataverse") should not be present until you select the resource server
  4. Select resource server and hover mouse over Get from Dataverse and confirm that hostname in the href matches resource_server
  5. Repeat previous step for different resource server.
  6. (optionally) verify that links go into the right place
  7. Repeat for Zenodo

craig-willis
craig-willis approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@craig-willis craig-willis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from whole-tale/girder_wholetale#409

ThomasThelen
ThomasThelen approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@ThomasThelen ThomasThelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bodom0015
bodom0015 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@bodom0015 bodom0015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised 👍

@ThomasThelen ThomasThelen merged commit fcfe64b into master Mar 11, 2020
@ThomasThelen ThomasThelen deleted the 616_proper_docs_href branch March 11, 2020 01:35
@craig-willis craig-willis mentioned this pull request Apr 1, 2020
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasThelen ThomasThelen ThomasThelen approved these changes

@craig-willis craig-willis craig-willis approved these changes

@bodom0015 bodom0015 bodom0015 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xarthisius @bodom0015 @craig-willis @ThomasThelen