Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo2docker version to the Tale manifest. Fixes #388 #410

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

Xarthisius
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #410 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   90.65%   90.66%   +0.01%     
==========================================
  Files          47       47              
  Lines        3510     3515       +5     
==========================================
+ Hits         3182     3187       +5     
  Misses        328      328
Impacted Files Coverage Δ
server/lib/manifest.py 90% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6c5c4...27932db. Read the comment docs.

@ThomasThelen
Copy link
Member

To Test:

  1. Checkout and deploy
  2. Launch a Tale instance
  3. Export it
  4. Examine the Tale manifest and look for schema:hasPart
  5. Create (but don't launch) a Tale
  6. Export & examine manifest again

@ThomasThelen ThomasThelen self-requested a review March 9, 2020 20:05
@Xarthisius Xarthisius merged commit 18f4740 into master Mar 16, 2020
@Xarthisius Xarthisius deleted the add_repo2docker_version branch March 16, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants