Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: view for a running tale should display interact #179

Merged
merged 2 commits into from
May 15, 2021
Merged

fix: view for a running tale should display interact #179

merged 2 commits into from
May 15, 2021

Conversation

Xarthisius
Copy link
Contributor

Problem

View tale when tale is running should display interact page, not metadata

How to Test

  1. Run a Tale
  2. Click on the view button.

bodom0015
bodom0015 approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@bodom0015 bodom0015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for submitting this one. I also added a small change so that Public Tales go to Metadata (since Interact is not guaranteed to work for all Public Tales)

@craig-willis craig-willis mentioned this pull request May 15, 2021
Closed
65 tasks
@Xarthisius Xarthisius merged commit 443db1c into master May 15, 2021
@Xarthisius Xarthisius deleted the view_to_interact branch May 15, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-willis craig-willis craig-willis approved these changes

@bodom0015 bodom0015 bodom0015 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xarthisius @bodom0015 @craig-willis