More typescript conversion #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @whscullin said in PR whscullin#38, there's no need to have both readable and writable pages since all implementations are currently both. This change combines them into `Page`. Likewise, `PageHandler` now extends `Page`. `Apple2IO` now implements `PageHandler`. This caught a bug where `end` had been renamed `endend` by mistake. There are a few other formatting changes as well.
Now all of the ROMs are classes that extend the ROM class. There is some rudamentary checking to make sure that the length of the ROM matches the declared start and end pages. (This caught what looks to be an error in roms/apple2e, but it's hard for me to tell.) The typing also caught an error where the character ROM was being used for the main ROM for the apple2j version.
This change also seems to fix a bug with `.po` image files that weren't being read correctly.
|
These all seem great, I can land it now or is there more in the works? |
|
There are always more in the works :-), but probably nothing until next weekend. I can just keep creating PRs until everything is done, or I can pile it all on this one. If you're planning changes, then probably landing this soon is better. It's up to you, really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts:
js/ram.tsto be a Typescript classjs/mmu.jsto Typescriptjs/apple2ioto Typescriptjs/canvasto Typescriptjs/apple2to Typescriptjs/prefsto Typescriptjs/roms/*to Typescriptjs/formats/format_utilsto TypescriptThese conversions were done fairly mechanically, so there is probably room for improvement.
Also, there is a change that combines the two interfaces
ReadablePageandWriteablePageintoPageand combines the page arrays.