Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning to the vha file #9

Closed
cal2195 opened this issue Dec 12, 2018 · 2 comments · Fixed by #93
Closed

Add versioning to the vha file #9

cal2195 opened this issue Dec 12, 2018 · 2 comments · Fixed by #93
Labels
breaking This is a breaking change enhancement Improves existing features
Milestone

Comments

@cal2195
Copy link
Collaborator

cal2195 commented Dec 12, 2018

Without a version field in the vha file, it's hard to work out what type of vha you are opening, and how to convert it to a new version.

We should add a version field, so that we can add backward compatibility properly. (We can assume no version means <=v1.3.0).

@cal2195 cal2195 added the enhancement Improves existing features label Dec 12, 2018
@cal2195 cal2195 added this to the v1.4.0 milestone Dec 12, 2018
@whyboris
Copy link
Owner

It may now be very easy to detect the old format: just see if we have an array of arrays rather than an array of objects, or simply if the screenshotHeight is missing (the renamed version of the field).

I think we should not worry about this issue until we're close to releasing v2.0.0 - and then we'll see what kind of a message we'll show to the user (probably will be easiest to say "sorry this file is an old format, please re-create the hub in the new system" 😅

@cal2195 cal2195 added the breaking This is a breaking change label Jan 4, 2019
@whyboris whyboris modified the milestones: v2.0.0, Ideas Jan 5, 2019
@cal2195
Copy link
Collaborator Author

cal2195 commented Jan 5, 2019

I think we should definitely add this to the vha file for v2.0.0 - it's one field at the top, and will help with future changes! 👍

@whyboris what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change enhancement Improves existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants