Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For More Thumbnail Import Settings #17

Closed
cal2195 opened this issue Dec 13, 2018 · 6 comments · Fixed by #138
Closed

Add Support For More Thumbnail Import Settings #17

cal2195 opened this issue Dec 13, 2018 · 6 comments · Fixed by #138
Labels
enhancement Improves existing features feature request New features
Milestone

Comments

@cal2195
Copy link
Collaborator

cal2195 commented Dec 13, 2018

As well as thumbnail size, it would be nice to support more properties such as:

  • JPEG and Video Compression
  • Number of thumbnails to extract
  • Number and length of video clips to extract
  • Disabling thumbnail or video clip generation
  • Option to enable extracting thumbnails on startup Extract Thumbnails on Startup #15

Customise everything! 👍

@cal2195 cal2195 added enhancement Improves existing features feature request New features labels Dec 13, 2018
@cal2195 cal2195 added this to the Soon milestone Dec 13, 2018
@whyboris
Copy link
Owner

Seems like the jpg quality is relatively easy to set with ffmpeg (e.g. -qscale:v 2), right? 😁

@cal2195 cal2195 modified the milestones: Soon, v2.0.0 Jan 2, 2019
@whyboris
Copy link
Owner

whyboris commented Jan 29, 2019

I've been struggling while thinking of a clean UI for the selection for number of thumbnails to extract.

Currently:
A single dropdown with set options in two categories:

  • fixed number of screenshots per video (e.g. 10 per video)
  • fixed number of screenshots per some duration of video (e.g. 1 per 5 minute)

Desired:
Give the ability for the user to choose the number per video or number per some duration. Easy conceptually, but how do we represent this choice visually?

I'm thinking <input type="number"> with some min and max already set (example).

Maybe something like this:

 ____
|  n |   ( ) screenshots per video
|____|   (*) screenshots every hour

a large size input on the left with two radio buttons on the right.

I just wish users wouldn't have to do math in their head and choose N from 1 screenshot every N minutes.

Maybe a radio box with two independent inputs?

( ) [ n +/- ] screenshots per video
(*) 1 screenshot every [ n +/- ] minutes

Might be easier ... just unfortunate that the number input will then be either small, or will disrupt the flow of text a bit. I'll play with the css to make it as nice as possible.

@cal2195 - thoughts?

@cal2195
Copy link
Collaborator Author

cal2195 commented Jan 29, 2019

I like this idea a lot - although do we need to limit it to a max? No max, or at least a very large max will allow for greater use cases we haven't thought of! 😄

I prefer the second idea - makes more intuitive sense! 👍

@whyboris
Copy link
Owner

Work in progress: branch thumbnail-number-selection is half-ready.
Visually done, just needs underlying code updates to propagate the numbers back to node 👌

@whyboris
Copy link
Owner

whyboris commented Feb 1, 2019

Will look like this 👌

image

@whyboris
Copy link
Owner

whyboris commented Feb 1, 2019

Currently can't do more frequently than 1 screenshot every 1 minute (limitation of the HTML selection box - can be changed sometime later maybe, not in a rush though).
Also the maximum will likely be changed in the future -- current PR sets it to 30 per video (arbitrarily).

I'll test things out sometime with a large number just to see how the app behaves. I wouldn't want to allow a setting that grinds the app to a halt 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing features feature request New features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants