make sure merger doesnt affect model type #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 723178309Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
andyndang
requested changes
Apr 6, 2021
lalmei
commented
Apr 6, 2021
andyndang
reviewed
Apr 7, 2021
andyndang
reviewed
Apr 8, 2021
| @@ -1,5 +1,5 @@ | |||
| [bumpversion] | |||
| current_version = 0.4.4-dev0 | |||
| current_version = 0.4.5-dev1 | |||
There was a problem hiding this comment.
Wait. Why is 0.4.5-dev1? Did we release 0.4.4?
There was a problem hiding this comment.
bump2version build should push this to 0.4.4-dev1 FYI (just tested locally)
commit 5f9a5a1d091384d313d4f20f53a2e71308268ca9 (HEAD -> mainline)
Author: Andy Dang🤖 <andy@whylabs.ai>
Date: Wed Apr 7 20:07:59 2021 -0700
Bump version: 0.4.4-dev2 → 0.4.4-dev3
commit 2e4ae1285d9f394888b74cac4e410560f18e4ccd
Author: Andy Dang🤖 <andy@whylabs.ai>
Date: Wed Apr 7 20:07:50 2021 -0700
Bump version: 0.4.4-dev1 → 0.4.4-dev2
commit bee1ca3f47d2566ff309051dc14058a528a9ee19
Author: Andy Dang🤖 <andy@whylabs.ai>
Date: Wed Apr 7 20:07:49 2021 -0700
Bump version: 0.4.4-dev0 → 0.4.4-dev1
|
LGTM but I certainly defer to Andy |
cswarth
approved these changes
Apr 9, 2021
…s-python into WHY-2694_fix_merger_issue
|
@andyndang your review is blocking |
andyndang
approved these changes
Apr 10, 2021
| @@ -1,5 +1,5 @@ | |||
| [bumpversion] | |||
| current_version = 0.4.4-dev0 | |||
| current_version = 0.4.5-dev1 | |||
There was a problem hiding this comment.
bump2version build should push this to 0.4.4-dev1 FYI (just tested locally)
commit 5f9a5a1d091384d313d4f20f53a2e71308268ca9 (HEAD -> mainline)
Author: Andy Dang🤖 <andy@whylabs.ai>
Date: Wed Apr 7 20:07:59 2021 -0700
Bump version: 0.4.4-dev2 → 0.4.4-dev3
commit 2e4ae1285d9f394888b74cac4e410560f18e4ccd
Author: Andy Dang🤖 <andy@whylabs.ai>
Date: Wed Apr 7 20:07:50 2021 -0700
Bump version: 0.4.4-dev1 → 0.4.4-dev2
commit bee1ca3f47d2566ff309051dc14058a528a9ee19
Author: Andy Dang🤖 <andy@whylabs.ai>
Date: Wed Apr 7 20:07:49 2021 -0700
Bump version: 0.4.4-dev0 → 0.4.4-dev1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.