-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable data to be logged to WhyLabs anonymous sessions #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8 is failing FYI |
lalmei
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
naddeoa
force-pushed
the
anonymous-sessions-rc1
branch
from
April 8, 2021 14:55
12a5e06
to
04cea33
Compare
… an example script for logging data via whylabs
…ned flow | fix some edge cases with whylabs client wrapper
Loggers now are stored with the key of the arguments that defined them. This means there will be new loggers created for every new timestamp, dataset name, tags, etc. Not 100% sure if this is what we want for this API so I'll have to check with everyone else. It is definitely better then what's there but it may not be right.
This adds a snapshot of a dataset from kaggle (https://www.kaggle.com/yugagrawal95/sample-media-spends-data) and an example that shows how properly log that data to whylogs for an anonymous session on WhyLabs. This dataset actually has a day date column so its much clearer how the logger is supposed to work in regards to dates.
naddeoa
force-pushed
the
anonymous-sessions-rc1
branch
from
April 8, 2021 14:59
04cea33
to
0278f8e
Compare
Pull Request Test Coverage Report for Build 729964070Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a feature to whylogs that allows it to log data to
WhyLabs anonymous sessions. Anonymous sessions allow people to jump into
whylogs with a dataset, log it to dataset profiles, and send it to
WhyLabs for visualization and alerts without requiring a login.
This change updates whylogs to have a
Session
concept that isessentially a wrapper around a bunch of loggers. Sessions manage
loggers and logger life cycles, as well as call WhyLabs to create and
sessions and upload the dataset profiles that loggers create.
This also adds an example for anonymous sessions with dates
This adds a snapshot of a dataset from kaggle
(https://www.kaggle.com/yugagrawal95/sample-media-spends-data) and an
example that shows how properly log that data to whylogs for an
anonymous session on WhyLabs. This dataset actually has a day date
column so its much clearer how the logger is supposed to work in regards
to dates.