Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move proto to whylogs #197

Merged
merged 23 commits into from
Apr 11, 2021
Merged

Move proto to whylogs #197

merged 23 commits into from
Apr 11, 2021

Conversation

andyndang
Copy link
Contributor

First step to unifying the repos

Moving proto submodule into whylogs repo while preserving the history.

commit 12296693f095fba83cbbc0214c22e29e14f926d5 (HEAD -> dev/andy/unity, origin/dev/andy/unity)
Merge: a86bba8 083464b
Author: Andy Dang🤖 <andy@whylabs.ai>
Date:   Fri Apr 9 15:15:31 2021 -0700

    Add 'proto/' from commit '083464b1e5fdc200b3118e8621b0e99346d045f9'

    git-subtree-dir: proto
    git-subtree-mainline: a86bba828de783a0e031b7b84c2575862bd10f7a
    git-subtree-split: 083464b1e5fdc200b3118e8621b0e99346d045f9

commit a86bba828de783a0e031b7b84c2575862bd10f7a
Author: Andy Dang🤖 <andy@whylabs.ai>
Date:   Fri Apr 9 15:15:24 2021 -0700

    Remove submodule

Andy Dang🤖 and others added 22 commits August 14, 2020 17:16
Add support for classification metrics
Update schema to support collection matrix of scores
- docstrings
- some renaming of fields and methods
WIP: WHY-2306 constraint protobuf definitions
git-subtree-dir: proto
git-subtree-mainline: a86bba8
git-subtree-split: 083464b
@andyndang andyndang requested a review from lalmei April 9, 2021 22:17
@coveralls
Copy link

coveralls commented Apr 9, 2021

Pull Request Test Coverage Report for Build 734511764

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 82.644%

Totals Coverage Status
Change from base Build 730144377: -0.06%
Covered Lines: 3185
Relevant Lines: 3706

💛 - Coveralls

Copy link
Contributor

@lalmei lalmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei
Copy link
Contributor

lalmei commented Apr 10, 2021

@andyndang should be good once the conflicts are solved

@lalmei lalmei added the enhancement New feature or request label Apr 10, 2021
@andyndang andyndang merged commit 1707e20 into mainline Apr 11, 2021
@andyndang andyndang deleted the dev/andy/unity branch April 11, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants