Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number of tokens in StringTracker merge #256

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fix number of tokens in StringTracker merge #256

merged 1 commit into from
Jul 9, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Jul 9, 2021 •
edited

Description

Fix a bug in string tracker with additional unit test to cover it.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the bug Something isn't working label Jul 9, 2021
@lalmei lalmei changed the title Fix number of token tracker merge Fix number of tokens in StringTracker merge Jul 9, 2021
cswarth
cswarth approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@cswarth cswarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1016099076

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.419%
Totals Coverage Status
Change from base Build 1012518999: 0.0%
Covered Lines: 3489
Relevant Lines: 4081
💛 - Coveralls

@lalmei lalmei merged commit bcb3cfd into mainline Jul 9, 2021
@lalmei lalmei deleted the token_length_merge_fix branch July 9, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswarth cswarth cswarth approved these changes

@andyndang andyndang Awaiting requested review from andyndang

@bernease bernease Awaiting requested review from bernease

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lalmei @coveralls @cswarth