Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of tokens in StringTracker merge #256

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Jul 9, 2021

Description

Fix a bug in string tracker with additional unit test to cover it.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the bug Something isn't working label Jul 9, 2021
@lalmei lalmei changed the title Fix number of token tracker merge Fix number of tokens in StringTracker merge Jul 9, 2021
Copy link
Contributor

@cswarth cswarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1016099076

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.419%

Totals Coverage Status
Change from base Build 1012518999: 0.0%
Covered Lines: 3489
Relevant Lines: 4081

💛 - Coveralls

@lalmei lalmei merged commit bcb3cfd into mainline Jul 9, 2021
@lalmei lalmei deleted the token_length_merge_fix branch July 9, 2021 19:23
@coveralls
Copy link

coveralls commented Oct 5, 2024

Pull Request Test Coverage Report for Build 1016099076

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.362%

Totals Coverage Status
Change from base Build 1012518999: 0.0%
Covered Lines: 3489
Relevant Lines: 4081

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants