Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging for non-tracked character positions #257

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Fix merging for non-tracked character positions #257

merged 2 commits into from
Jul 12, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Jul 12, 2021 •
edited
Loading

Description

Fix merging of non-tracked characters.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the bug Something isn't working label Jul 12, 2021
@lalmei lalmei requested a review from cswarth July 12, 2021 20:14
cswarth
cswarth requested changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@cswarth cswarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also you check for this at the end of test_stringtracker.py::test_merge please.

cswarth
cswarth approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@cswarth cswarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jul 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1024212788

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 82.125%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/core/statistics/stringtracker.py 6 8 75.0%
Totals Coverage Status
Change from base Build 1018684440: -0.03%
Covered Lines: 3618
Relevant Lines: 4248
💛 - Coveralls

@lalmei lalmei changed the title WIP: Fix merging for NITL Fix merging for NITL Jul 12, 2021
@lalmei lalmei changed the title Fix merging for NITL Fix merging for non-tracked character positions Jul 12, 2021
@lalmei lalmei merged commit 563b2a4 into mainline Jul 12, 2021
@lalmei lalmei deleted the string_merge_fix_NTIL branch July 12, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswarth cswarth cswarth approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lalmei @coveralls @cswarth