-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValueConstraint: Assert column values in set #375
Conversation
… edit SummaryConstraint class and SummaryConstraintMsg accordingly, unit tests for BTWN
…straint, minGreaterThanEqualConstraint, maxBetweenConstraint and maxLessThanEqualConstraint.
Pull Request Test Coverage Report for Build 1581390881Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, (pending Richard's comments are addressed), and the tests are nice! I left a few questions and comments.
…t[Any], simplified condition for checking constraints with IN operator, added assertions and logger in test cases for constraints
Description
IN operator, new field for the set in ValueConstraintMsg, checks for value errors, adapting to_protobuf and from_protobuf.
Function columnValuesInSetConstraint() and tests for the changes
General Checklist
if it was a bug, test must cover it.