Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git submodules in Java workflows #396

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Conversation

richard-rogers
Copy link
Contributor

Description

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@jamie256
Copy link
Contributor

Let's update this to use the local proto definitions: https://github.com/whylabs/whylogs/tree/mainline/proto/src

Python already builds the proto definitions so no need to update that side of our build step or workflow.

The submodule approach is part of the previous factorization when the java package was separate from the python whylogs. Let's restructure this workflow to not depend on submodules. We can move the proto folder, but lets centralize the local definitions as the authority for message definitions in whylogs.

@richard-rogers richard-rogers changed the title Use git submodules in Java workflows Remove git submodules in Java workflows Dec 23, 2021
@richard-rogers
Copy link
Contributor Author

Let's update this to use the local proto definitions

Looking at the sub-level build.gradle.kts, I think it's already setup to use the local proto stuff. I think it just depends on the Python build happening first to build proto.

I also bumped log4j in this PR to deal with the latest vulnerabilities.

@coveralls
Copy link

coveralls commented Dec 23, 2021

Pull Request Test Coverage Report for Build 1617747775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.037%

Totals Coverage Status
Change from base Build 1612988554: 0.0%
Covered Lines: 3881
Relevant Lines: 4662

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamie256 jamie256 merged commit 14fa853 into mainline Dec 28, 2021
@jamie256 jamie256 deleted the dev/richard/submodules branch December 28, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants