-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feast integration demo #454
Add feast integration demo #454
Conversation
Pull Request Test Coverage Report for Build 1895144890Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the data (parquet files) out of the whylogs repo? I know its relatively small but it would be better to separate these.
- Changes in code to make notebook pass test - Changed manner of materializing, to make the notebook run faster - Added descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Add feast-whylogs integration demo in
examples
:General Checklist
if it was a bug, test must cover it.