Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feast integration demo #454

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

FelipeAdachi
Copy link
Contributor

Description

Add feast-whylogs integration demo in examples:

  • Jupyter notebook
  • Sample parquet data files
  • Images
  • Feast infra files

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Feb 23, 2022

Pull Request Test Coverage Report for Build 1895144890

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.526%

Totals Coverage Status
Change from base Build 1888783176: 0.0%
Covered Lines: 4767
Relevant Lines: 5626

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the data (parquet files) out of the whylogs repo? I know its relatively small but it would be better to separate these.

- Changes in code to make notebook pass test
- Changed manner of materializing, to make the notebook run faster
- Added descriptions
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FelipeAdachi FelipeAdachi merged commit d022644 into whylabs:mainline Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants