Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc install action in push_release.yml to match tests #516

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

jamie256
Copy link
Contributor

@jamie256 jamie256 commented Apr 6, 2022

Description

Follow up from yanked release 0.7.3, this should resolve that issue where we pulled latest protoc to build the released wheels which then referenced the new builder type in protobuf which is not backwards compatible with older protobuf.

This now matches our python ci config.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Apr 6, 2022

Pull Request Test Coverage Report for Build 2103815105

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.615%

Totals Coverage Status
Change from base Build 2097481499: 0.0%
Covered Lines: 4943
Relevant Lines: 5819

💛 - Coveralls

@jamie256 jamie256 merged commit 5fb248a into mainline Apr 6, 2022
@jamie256 jamie256 deleted the dev/jamie/protoc branch April 6, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants