Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache restore bug in gh issue #1377 by fixing paths #15

Merged

Conversation

devsh4
Copy link

@devsh4 devsh4 commented Nov 28, 2023

There's an open issue in @actions/toolkit that uncovers a major bug with cache restores not working after v3.1.1 of @actions/cache.

On attempting to upgrade and use v3-s3 of this action, we ran into similar issues and the below PR is to fix the underlying issue until the upstream PR is merged.

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devsh4
Copy link
Author

devsh4 commented Nov 28, 2023

@whywaita please review.

@devsh4
Copy link
Author

devsh4 commented Dec 1, 2023

@whywaita Were you able to review? I see the check dist CI step failing but assuming it's not related to this PR. Thanks!

@whywaita
Copy link
Owner

whywaita commented Dec 2, 2023

I will review it. But We need to fix CI in this pr.

@whywaita
Copy link
Owner

whywaita commented Dec 2, 2023

@devsh4 Did you write a comment under dist/*.js?

dist directory must generate files from npm run build. We need to write a comment in .ts files if we want to write a comment.

@devsh4
Copy link
Author

devsh4 commented Dec 4, 2023

@whywaita my bad, that was a bad copy/paste and I thought I pushed the commit. Should be good now.

@devsh4 devsh4 force-pushed the bugfix/cache-restore-fails-issue-1377 branch from 6be557d to c56a799 Compare December 4, 2023 14:10
@devsh4 devsh4 force-pushed the bugfix/cache-restore-fails-issue-1377 branch from c56a799 to 289f2b2 Compare December 4, 2023 14:39
@markandrus
Copy link

markandrus commented Dec 5, 2023

Previous message

Thanks for this, @devsh4.

Is this fix working for y'all? I pointed my GitHub workflow to your fork to try it, but I still see "not found" failures like this

Cache not found for input keys: v1-Linux-ARM64-8ece81f19f8907841274feda72820220bb97cc28784a63e9ef9b00aea8729635, v1-Linux-ARM64-

even though the "v1-Linux-ARM64-8ece81f19f8907841274feda72820220bb97cc28784a63e9ef9b00aea8729635" does in fact exist in the S3 bucket. I cannot tell if this is the bug or not.

EDIT: Nevermind, I realize I was hitting a different issue, and have opened this PR: whywaita/actions-toolkit-s3#11

@devsh4
Copy link
Author

devsh4 commented Dec 20, 2023

@whywaita any concerns or is this PR good to merge?

@whywaita whywaita merged commit 9b747ac into whywaita:main Dec 22, 2023
15 checks passed
@whywaita
Copy link
Owner

Sorry late. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants