-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET_URL vs GET_ALLOWED_ORIGINS #39
Comments
OK, so I think that I get it now. The GET_ALLOWED_ORIGINS doesn't actually return any origins (urls) just an index of how many exists. That makes its name a bit confusing. Could we add _HEADER at the end, ie. GET_ALLOWED_ORIGINS_HEADER? As an Origin is a subset of URLs, renaming GET_URL to GET_ALLOWED_ORIGIN makes more sense, it also makes it clear that what returned won't contain path, queries or fragments |
gentle ping @reillyeon |
GET_URL returns URL descriptors which are used not only for allowed origins but also the device's landing page. To me adding "_HEADER" would imply that GET_ALLOWED_ORIGINS only returns the "Allowed Origins Header" and not configuration or function subsets. Given that in the new scheme URLs are not included in this data it makes sense to me to remove the "header" name from the spec as a single "Allowed Origins Descriptor" is perfectly valid if all listed origins have full access to the device. |
If the former is just for getting an individual index of the allowed origins, I find it weird that the name is so different. Why not just GET_ALLOWED_ORIGIN or GET_ALLOWED_ORIGIN_AT
The text was updated successfully, but these errors were encountered: