fix ensure_future errors in python 3.7+ #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin is broken on home assistant .88 and above. The file has been modified to change all instances of "ensure_future" to "asyncio.ensure_future". With these changes, the plugin works correctly again in home assistant .88+.
|
Hi, thanks for this. Can you clean up all of the additional whitespace in the PR please? |
|
done! Huge pain in the ass sorry for all the commits. I copy/pasted my code instead of modifying the existing code which created all those whitespace changes. It's all cleaned up now. Let me know if that works for you. |
|
Should I just do a new clean PR? I see now it wants to merge all my commits instead of the latest. Sorry. Not something I do often obviously. Or perhaps you can see my changes and just update yourself. It's a very simple update. |
|
I have addressed this in a way that will still work for python 3.4+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin is broken on home assistant .88 and above. The file has been modified to change all instances of "ensure_future" to "asyncio.ensure_future". With these changes, the plugin works correctly again in home assistant .88+.